Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

des-2292: Co-Pis now appears without hypertext #1084

Merged

Conversation

van-go
Copy link
Contributor

@van-go van-go commented Aug 10, 2023

Overview:

When on the Publication Preview for a type Other project, the Co-PIs do not appear.
They now appear but like PI, they are NOT hyperlinked. Checked that the citation preview for type Other also has the correct authors list (My Projects & Published).

PR Status:

  • Ready.
  • Work in Progress.
  • Hold.

Related Jira tickets:

Summary of Changes:

In prj-pub-preview-metadata-template.html, I used similar code from PIs (type Other) to display Co-PIs (type Other). This is specific for type Other; all other types grab these fields in a different way.

Testing Steps:

  1. Find a type Other project that has Co-PI(s)
  2. In My Projects, in Working Directory, verify that Co-PIs appear (should be hyperlinked)
  3. Click on Publication Preview, verify that Co-PIs appear (should not be hyperlinked)

UI Photos:

BEFORE
Screen Shot 2023-08-10 at 11 59 52 AM

AFTER
Screen Shot 2023-08-10 at 3 45 42 PM

Notes:

I tried to hyperlink the Co-PIs, but they are displaying as a single unit. So if there are 2+ Co-PIs, there is only 1 hyperlink. Since the PI wasn't hyperlinked, I just left that off of Co-PIs.

@jarosenb jarosenb merged commit c078244 into main Aug 16, 2023
2 checks passed
@jarosenb jarosenb deleted the bug/des-2292-copis-type-other-pub-preview-not-showing branch August 16, 2023 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants